Skip site navigation (1) Skip section navigation (2)

Re: Display Pg buffer cache (WIP)

From: Neil Conway <neilc(at)samurai(dot)com>
To: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Display Pg buffer cache (WIP)
Date: 2005-03-08 06:26:10
Message-ID: 422D4582.3000208@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Mark Kirkwood wrote:
> + 		tupledesc = CreateTemplateTupleDesc(NUM_BUFFERCACHE_PAGES_ELEM, false);
> + 		TupleDescInitEntry(tupledesc, (AttrNumber) 1, "bufferid",
> + 									INT4OID, -1, 0);
> + 		TupleDescInitEntry(tupledesc, (AttrNumber) 2, "relfilenode",
> + 									OIDOID, -1, 0);
> + 		TupleDescInitEntry(tupledesc, (AttrNumber) 3, "reltablespace",
> + 									OIDOID, -1, 0);
> + 		TupleDescInitEntry(tupledesc, (AttrNumber) 4, "reldatabase",
> + 									OIDOID, -1, 0);
> + 		TupleDescInitEntry(tupledesc, (AttrNumber) 5, "relblockbumber",
> + 									NUMERICOID, -1, 0);

I think this should be an int4, not numeric.

Otherwise, looks good to me. Barring any objections, I'll apply this 
with a few stylistic tweaks and the numeric -> int4 change tomorrow.

-Neil

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2005-03-08 06:54:56
Subject: Re: Display Pg buffer cache (WIP)
Previous:From: Christopher Kings-LynneDate: 2005-03-08 04:27:21
Subject: Re: Best practices: MERGE

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group