Skip site navigation (1) Skip section navigation (2)

Re: Display Pg buffer cache (WIP)

From: Neil Conway <neilc(at)samurai(dot)com>
To: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Display Pg buffer cache (WIP)
Date: 2005-03-06 08:49:05
Message-ID: 422AC401.3020702@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Only two things to add: you forgot to add `cachedump.o' to the list of 
OBJS in the utils/adt Makefile.

Mark Kirkwood wrote:
> +typedef struct
> +{
> +	uint32		bufferid;
> +	Oid			relfilenode;
> +	Oid			reltablespace;
> +	Oid			reldatabase;
> +	bool		isdirty;
> +	uint32		refcount;
> +	BlockNumber	blocknum;
> +
> +} CacheDumpRec;

You should probably make `isdirty' the last member of this struct, so as 
to reduce alignment/padding requirements (this won't actually save any 
space right now, but it might save some space if more members are added 
to the struct in the future).

-Neil

In response to

pgsql-patches by date

Next:From: Pavel StehuleDate: 2005-03-06 19:24:38
Subject: Implementation of SQLCODE and SQLERRM variables for PL/pgSQL
Previous:From: Neil ConwayDate: 2005-03-06 08:13:17
Subject: Re: Display Pg buffer cache (WIP)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group