Max Khon wrote:
> Attached patch fixes coredump in non-Unicode version of pgadmin3.
> This allows to build (non-Unicode) pgadmin3 on FreeBSD 4.x.
This patch appears highly dubious to me (apart from the fact that I'd
call non-unicode unsupported).
> +#if wxUSE_UNICODE
> + size_t buf_len = nLen;
> + size_t buf_len = nLen * sizeof(wchar_t);
(const char*)buffer, (size_t)(nLen+1));
wxStringBuffers expects the second parameter to contain the number of
characters (not bytes), which will be the same for unicode as and
non-unicode. Using sizeof(wchar_t) in non-unicode is just an arbitrary
number with no special meaning, might be the magic constant 42 as well.
The only mechanism of "fix" I could think of is that wxStringBuffer
really should receive nLen+1 instead of nLen.
Max, apparently you have a test case, please check nLen+1 instead of
In response to
pgadmin-hackers by date
|Next:||From: Andreas Pflug||Date: 2005-02-23 22:39:22|
|Subject: Re: upgrade to wx2.5.4|
|Previous:||From: Dave Page||Date: 2005-02-23 21:21:30|
|Subject: Re: [pgadmin-support] [ANNOUNCE] pgAdmin III 1.2.0 Released|