Re: [HACKERS] dropdb/contrib-regression

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] dropdb/contrib-regression
Date: 2004-12-14 01:44:53
Message-ID: 41BE4595.5050908@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>I guess we could put a small sleep before dropdb in pg_regress.sh to
>>
>>
>
>I'd prefer to put it in contrib/Makefile's installcheck rule, so that
>we don't pay the price in contexts where it's not needed.
>
>

tiny patch attached. For reasons Tom cited related to scheduler it isn't
guaranteed to fix the problem, only to lower the likelihood of occurrence.

>A more radical solution would be to tweak libpq's PQfinish() to be a
>synchronous close, ie, wait for the backend to exit before returning.
>I think we've speculated about doing that in the past, but never been
>fully convinced that it's worth the downside of usually-unnecessary
>client delay.
>
>

Sufficient unto the day .... seems to me making it synchronous could be
a cure as bad as the disease.

cheers

andrew

Attachment Content-Type Size
contribmake.patch text/x-patch 522 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Neil Conway 2004-12-14 03:39:49 Re: dropdb/contrib-regression
Previous Message Tom Lane 2004-12-14 00:29:53 Re: dropdb/contrib-regression

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-12-14 01:59:16 Re: pg_resetxlog as root
Previous Message Robert Treat 2004-12-14 01:43:14 small typo in create user --help