Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Instead of supposing (wrongly, in the general

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Instead of supposing (wrongly, in the general
Date: 2004-12-12 07:11:35
Message-ID: 41BBEF27.9050308@samurai.com (view raw or flat)
Thread:
Lists: pgsql-committers
Tom Lane wrote:
> Instead of supposing (wrongly, in the general case) that the rowtype
> of an inheritance child table is binary-compatible with the rowtype of
> its parent, invent an expression node type that does the conversion
> correctly.  Fixes the new bug exhibited by Kris Shannon as well as a
> lot of old bugs that would only show up when using multiple inheritance
> or after altering the parent table.

Attached is a patch adding regression tests for this change. I'll apply 
it to HEAD later tonight or tomorrow baring any objections. I just used 
the two test cases posted in the -hackers thread; Tom, if you have any 
other test cases for this behavior in mind, just let me know.

-Neil

Attachment: inh_rowtype_cast_test-1.patch
Description: text/x-patch (1.8 KB)

In response to

Responses

pgsql-committers by date

Next:From: Peter EisentrautDate: 2004-12-12 15:34:20
Subject: pgsql: Fix problems with certain shells (e.g., FreeBSD, Cygwin) clearing
Previous:From: Tom LaneDate: 2004-12-12 05:07:57
Subject: pgsql: Upgrade formrdesc() so that it can correctly initialize the

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group