Skip site navigation (1) Skip section navigation (2)

Re: psql \! WIN32 cleanup

From: Gaetano Mendola <mendola(at)bigfoot(dot)com>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: psql \! WIN32 cleanup
Date: 2004-11-06 09:01:46
Message-ID: 418C92FA.4000908@bigfoot.com (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Bruce Momjian wrote:
> Tom Lane wrote:
> 
>>Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>>
>>>The attached applied patch tests for COMSPEC in the right place and
>>>supplies a reasonable shell default on Win32.
>>
>>>+ #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
>>
>>Is it really a good idea to assume that the Windows installation is on
>>drive C: ?
>>
>>(This is an honest question, not a rhetorical one.  I dunno whether
>>inserting the C: is better than leaving it off.  I can think of cases
>>where either way will break, but I'm unsure what's most likely in
>>practice.)
> 
> 
> Not sure.  Should we just do "/windows/system32/cmd.exe" and leave off
> the C:?  The previous default was "/bin/sh" and that certainly will not
> work on Win32.

I think another path to try if COMSPEC is not defined is:

%SystemRoot%/system32/cmd.exe



Regards
Gaetano Mendola


In response to

pgsql-patches by date

Next:From: Andrew McMillanDate: 2004-11-06 09:36:25
Subject: Re: [PATCHES] CVS should die
Previous:From: John A MeinelDate: 2004-11-06 06:10:49
Subject: Re: [PATCHES] psql \! WIN32 cleanup

pgsql-hackers-win32 by date

Next:From: Reini UrbanDate: 2004-11-07 16:55:09
Subject: Re: use of IDE's an tools
Previous:From: John A MeinelDate: 2004-11-06 06:10:49
Subject: Re: [PATCHES] psql \! WIN32 cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group