Re: Various bugs/issues

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Alexander Borkowski <alexander(dot)borkowski(at)abri(dot)une(dot)edu(dot)au>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Various bugs/issues
Date: 2004-11-04 09:04:48
Message-ID: 4189F0B0.8070006@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Alexander Borkowski wrote:
> Andreas Pflug wrote:
>
>>>> Type handling really needs a major rewrite
>
> ...
>
>> There's already some stuff in pgDatatype, but the class was invented
>> too late when I realized that typehandling is more complicated than it
>> appeared initially. Every string/parameter formatting/encoding should
>> be concentrated there. This involves some rewrite of type usage in
>> schema and ui files as well.
>
>
> Ok, I think I got the idea. Looks pretty interesting really, I will take
> a closer look at that during the weekend and see if I could handle it.
> The GUI part may be the problem for me there, as I have done mostly
> server-side stuff so far.

Since this is a little fragile, we won't do more than hotfixing on that
in 1.2.

>
> In the meantime, I found another bug in dlgCast (1.2.0 post-beta3,
> WinXP). I have only one candiate as cast function in my case but the
> list contains an empty string and the function name - four times, and
> only the first occurrence of the function name in this list leads to a
> sensible result in the SQL tab. This appears to be caused by not
> clearing cbFunctions when necessary, and I was able to fix this by adding
>
> cbFunctions->Clear();

Yup, this is the correct fix; applied to CVS.

>
> Also, when selecting
> 'New Cast' from the Casts context menu in the debug build version only,
> instead of the new cast dialog an error dialog with a message about an
> unhandled exception comes up (choices Abort, Retry, and Ignore). It
> still does after my change.

Hm, I don't see this here. Do you have a stack trace?

Regards,
Andreas

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2004-11-04 13:37:58 RC1 Uploaded
Previous Message cvs 2004-11-04 09:01:12 CVS Commit by andreas: Fix duplicate functions in Cast dialog