Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

From: Reini Urban <rurban(at)x-ray(dot)at>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, pgsql-cygwin(at)postgresql(dot)org
Subject: Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path
Date: 2004-10-27 18:17:28
Message-ID: 417FE638.8090209@x-ray.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-cygwin pgsql-hackers

Magnus Hagander schrieb:
>>beta4 - cygwin:
>>postgres.exe fails to build, because __imp__my_exec_path from
>>src/timezone/pgtz.o cannot be resolved. previously it was not
>>imported.
>
> This could be related to the patch that went in last weekend to fix
> compiles on Win32. DLLIMPORT was added to the header. If the Makefile
> did not change, then that is your problem - that patch changed botht he
> makefile and the header. See
> http://archives.postgresql.org/pgsql-committers/2004-10/msg00321.php
>
> Does CYGWIN perhaps need the same Makefile patch?

You only patched your Makefile.win32, not Makefile.cygwin. That's it. It
builds fine now.

Please add also

ifneq (,$(findstring timezone,$(subdir)))
override CPPFLAGS+= -DBUILDING_DLL
endif

to the Makefile.cygwin.
Without it doesn't break just contrib/tsearch, it even breaks cygwin
postmaster.

Maybe all win32.mak and bcc32.mak must also be checked. Does anybody do
the msvc/borland suites?
--
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

In response to

Responses

Browse pgsql-cygwin by date

  From Date Subject
Next Message Magnus Hagander 2004-10-27 18:25:45 Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path
Previous Message Magnus Hagander 2004-10-27 16:52:56 Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2004-10-27 18:25:45 Re: [HACKERS] src/timezone/pgtz __imp__my_exec_path
Previous Message Bruce Momjian 2004-10-27 18:00:25 Re: 8.0b4: COMMIT outside of a transaction echoes ROLLBACK