Re: rmtree() failure on Windows

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: rmtree() failure on Windows
Date: 2004-10-25 16:03:07
Message-ID: 417D23BB.4080706@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:

>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>Shown below is an extract from the traces of make installcheck in
>>contrib. It is decorated with some extra traces I built into
>>src/port/dirmod.c::rmtree(). It shows quite reproducible failure of
>>rmtree(), mostly at the rmdir calls, but even more worryingly there are
>>consistent unlink failures also.
>>
>>
>
>I kinda suspect that what you are looking at is a problem with the
>delayed-unlinking feature that we built to cope with Windows' inability
>to unlink open files, ie, it's being a little too slow to do the
>unlinks. Would you refresh my memory about exactly where and when the
>unlink happens if the initial try fails?
>
>
>
>

Same file, although Bruce says that looping code is now redundant, as we
open files in a way that allows unlinking even if they are open.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-10-25 16:03:12 Re: [PATCHES] ARC Memory Usage analysis
Previous Message Tom Lane 2004-10-25 15:56:35 Re: rmtree() failure on Windows

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-10-25 16:03:12 Re: [PATCHES] ARC Memory Usage analysis
Previous Message Tom Lane 2004-10-25 15:56:35 Re: rmtree() failure on Windows