Skip site navigation (1) Skip section navigation (2)

Re: initdb conf-files linebreaks

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: initdb conf-files linebreaks
Date: 2004-10-24 15:42:43
Message-ID: 417BCD73.6040502@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:

>>>Attached patch makes initdb generate the config files with windows
>>>linebreaks when running on windows. This makes it a lot easier for the
>>>user to edit the configuration files, since any win32 plaintext editor
>>>can be used (such as notepad for example).
>>>
>>>If this is acceptable, and the method is ok, please apply for beta4 so
>>>we can add some nice icons to the win32 installer :-)
>>>
>>> 
>>>
>>>      
>>>
>>Assuming this works, the far simpler change would (or should) 
>>be to open 
>>the file with "w" rather than PG_BINARY_W in all cases.
>>    
>>
>
>That does seem to work, yes. I thought there was some magic reason we
>were using PG_BINARY_W and not "w".. Assuming there isn't, attached
>patch is certainly cleaner.
>
>  
>
>

I don't recall. It's been there since before the code was even committed 
to CVS, by the look of it. Probably I was just trying to be as Unix-like 
as possible.

It might break if we feed it a Ctrl-Z, but that isn't likely in this 
case, is it?

cheers

andrew

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2004-10-24 15:56:43
Subject: Re: initdb conf-files linebreaks
Previous:From: Magnus HaganderDate: 2004-10-24 15:16:55
Subject: Re: initdb conf-files linebreaks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group