Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>> Back on track: if rename() does exist under Windows then my idea is
>> unreliable. Any other thoughts? How about #including <io.h> in port.h
>> (for Windows only of course) before we #define these things?
> Probably won't work, because pgrename and rename do not have the same
So? The compiler would see something like
extern linkage_spec rename(...);
extern int pgrename(...);
#define rename pgrename
so the conflict of linkage spec shouldn't bother anything.
> I posted the attached patch 4 days ago, with the comment
> "The attached patch will redefine unlink and rename only if FRONTEND is
> not defined.".
> I still believe this a good way to fix it.
The conflict would still exist. AFAICS it's pure chance that it's
not affecting any backend modules at the moment.
regards, tom lane
In response to
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2004-08-17 14:44:20|
|Subject: Re: libpq build problem with <io.h> on MS VC++|
|Previous:||From: Mark Cave-Ayland||Date: 2004-08-17 14:33:49|
|Subject: Re: [PATCHES] GUC variables invisible to contrib/ modules|
pgsql-hackers-win32 by date
|Next:||From: Aleksander Kmetec||Date: 2004-08-17 14:39:40|
|Subject: initdb & locale weirdness|
|Previous:||From: Fabien COELHO||Date: 2004-08-17 14:34:21|
|Subject: tablespace and sequences?|