Re: Bug in dlgCast

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Alexander Borkowski <alexander(dot)borkowski(at)abri(dot)une(dot)edu(dot)au>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Bug in dlgCast
Date: 2004-10-06 09:20:58
Message-ID: 4163B8FA.1080602@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Alexander Borkowski wrote:
> Dear all,
>
> I just encountered a bug in 1.2.0 Beta 2 (Win XP).
>
> When selecting the source or target type in the "New Cast" dialog, the
> application crashes. What IMHO happens is that the call to
> txtName->SetValue(wxEmptyString) in dlgCast::CheckChange()
> (src/ui/dlgCast.cpp line 121) generates a new wxEVT_COMMAND_TEXT_UPDATED
> event. This event triggers a call to dlgProperty::OnChange() which in
> turn calls the virtual dlgCast::CheckChange() and so on ... until
> pgAdmin crashes.

Your analysis is right. The problem is that txtName is handled in a
generalized way in dlgProperty, which handles user inputs, but in the
case of dlgCast it's a calculated non-editable name.

Fix: renamed to txtCastname.

Thanks for reporting!

Regards,
Andreas

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message cvs 2004-10-06 09:25:57 CVS Commit by andreas: Fix cast property crash [Alexander Borkowski]
Previous Message Alexander Borkowski 2004-10-06 03:31:27 Bug in dlgCast