Skip site navigation (1) Skip section navigation (2)

Re: patch: ensure testdbencoding test table is dropped

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: patch: ensure testdbencoding test table is dropped
Date: 2004-07-21 21:07:45
Message-ID: 40FEDB21.2040501@opencloud.com (view raw or flat)
Thread:
Lists: pgsql-jdbc
Kris Jurka wrote:
> 
> On Tue, 20 Jul 2004, Oliver Jowett wrote:
> 
>>It does ~1800 INSERTs -- that's going to take a while with autocommit 
>>on. Turning autocommit on for that one test adds ~15 seconds to the 
>>testsuite run on my machine against 7.4. I think 7.3 will be worse.
>>
> 
> 
> Is perhaps this test being a little overzealous.  Do we really need to 
> test every possible code point to determine if it is working or not?  
> Seems that testing even every 100th code point would be sufficient.

<shrug> Change it if you like -- I did the exhaustive test because it 
seemed cheap enough. Perhaps you could just increase STEP.

Either way, the current CVS testcase still doesn't drop the table when 
it's done.

-O

In response to

pgsql-jdbc by date

Next:From: Phil MoorsDate: 2004-07-21 21:16:22
Subject: Re: SSL URL
Previous:From: Kris JurkaDate: 2004-07-21 21:07:34
Subject: Re: V3 protocol + DECLARE problems

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group