Skip site navigation (1) Skip section navigation (2)

Re: logfile subprocess and Fancy File Functions

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logfile subprocess and Fancy File Functions
Date: 2004-07-20 21:35:00
Message-ID: 40FD9004.2060005@pse-consulting.de (view raw or flat)
Thread:
Lists: pgsql-patches
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> 
>>For logs I think pgsql_ is best because that filename is already
>>going to be long, and I don't usually like dashes in file names. 
>>They look too much like arguments, but tarballs use them and it looks
>>OK there, I guess.
> 
> 
> I wasn't talking about what looks best, I was talking about current 
> practice for log files.  From that you might be able to extrapolate 
> what other people have previously found to look best.
> 
> In any case, we're not using DOS and 12 inch monitors any more.  File 
> names can be as long as we want.
> 

Before the thread concentrates too much on a decent default value, I'm 
posting a fresh version of the patch, for some more discussion. Current 
default for pg_logfile_prefix is 'postgresql-', may the committers 
decide which name is The Perfect One.

All previous suggestions have been included, (nb: abstimein is not 
usable, because it ereports(ERROR) on failure; we want to skip wrong 
files gracefully, so I'm using ParseDateTime and DecodeDateTime instead).

I'd still need feedback on pg_dir_ls: should it merely return a setof 
text, or should I enrich it to a record returning all stat data? After 
spending another thought on it, I believe the more sql-like approach is 
to deliver a full-featured record which is selected for the desired 
data, not adding columns with functions.

Regards,
Andreas


Attachment: logfile.diff
Description: text/x-patch (26.6 KB)
Attachment: syslogger.h
Description: text/x-chdr (656 bytes)
Attachment: syslogger.c
Description: text/x-csrc (13.3 KB)

In response to

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2004-07-20 21:44:33
Subject: Re: win32 readline
Previous:From: Bruce MomjianDate: 2004-07-20 20:36:40
Subject: Re: win32 readline

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group