Re: patch: ensure testdbencoding test table is dropped

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: patch: ensure testdbencoding test table is dropped
Date: 2004-07-20 06:24:41
Message-ID: 40FCBAA9.8070601@opencloud.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc

Kris Jurka wrote:
>
> On Tue, 20 Jul 2004, Oliver Jowett wrote:
>
>
>>Minor patch to make sure the testdbencoding test table is dropped
>>(otherwise it interferes with the table metadata test in subsequent runs).
>
>
> The only comment on messing with autocommit at all is "Go faster". Other
> tests avoid using transactions unless needed, what kind of speed up are we
> looking at here? 1 second? 10? It might just be easier to not mess with
> autocommit at all.

It does ~1800 INSERTs -- that's going to take a while with autocommit
on. Turning autocommit on for that one test adds ~15 seconds to the
testsuite run on my machine against 7.4. I think 7.3 will be worse.

-O

In response to

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Oliver Jowett 2004-07-20 09:04:50 Re: revisiting transaction isolation
Previous Message Kris Jurka 2004-07-20 06:03:56 Re: patch: ensure testdbencoding test table is dropped