Skip site navigation (1) Skip section navigation (2)

Re: logfile subprocess and Fancy File Functions

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: logfile subprocess and Fancy File Functions
Date: 2004-07-19 10:54:17
Message-ID: 40FBA859.2000709@pse-consulting.de (view raw or flat)
Thread:
Lists: pgsql-patches
Magnus Hagander wrote:

 > Super-minor nitpicking from just eyeing over the patch, not actually
 > checking how it works.

Reviewing the own code the most obvious things are overlooked.

 >
 > This patch changes the error message for pg_signal_backend() to "only
 > superuser may access generic file functions".
 >
 > I'm sure that was not intended.. You probably need to pass a parameter
 > to requireSuperuser() about what should go in the err msg.

Yes, seems I was a bit overenthusiastic...

 >
 > Also, I think you forgot to attach syslogger.h.

Indeed, attached is include/postmaster/syslogger.h

Regards,
Andreas

Attachment: syslogger.h
Description: text/x-chdr (620 bytes)

In response to

pgsql-patches by date

Next:From: a_ogawa00Date: 2004-07-19 13:24:42
Subject: regexp_replace
Previous:From: Simon RiggsDate: 2004-07-19 07:35:05
Subject: Re: [HACKERS] Point in Time Recovery

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group