Magnus Hagander wrote:
> Super-minor nitpicking from just eyeing over the patch, not actually
> checking how it works.
Reviewing the own code the most obvious things are overlooked.
> This patch changes the error message for pg_signal_backend() to "only
> superuser may access generic file functions".
> I'm sure that was not intended.. You probably need to pass a parameter
> to requireSuperuser() about what should go in the err msg.
Yes, seems I was a bit overenthusiastic...
> Also, I think you forgot to attach syslogger.h.
Indeed, attached is include/postmaster/syslogger.h
Description: text/x-chdr (620 bytes)
In response to
pgsql-patches by date
|Next:||From: a_ogawa00||Date: 2004-07-19 13:24:42|
|Previous:||From: Simon Riggs||Date: 2004-07-19 07:35:05|
|Subject: Re: [HACKERS] Point in Time Recovery|