Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Point in Time Recovery

From: Mark Kirkwood <markir(at)coretech(dot)co(dot)nz>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: markw(at)osdl(dot)org, pgman(at)candle(dot)pha(dot)pa(dot)us, kn(at)mgnet(dot)de,tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org,pgsql-admin(at)postgresql(dot)org
Subject: Re: [HACKERS] Point in Time Recovery
Date: 2004-07-15 01:43:38
Message-ID: 40F5E14A.4090003@coretech.co.nz (view raw or flat)
Thread:
Lists: pgsql-adminpgsql-hackerspgsql-patches
I noticed that compiling with 5_1 patch applied fails due to 
XLOG_archive_dir being removed from xlog.c , but 
src/backend/commands/tablecmds.c still uses it.

I did the following to tablecmds.c :

5408c5408
<               extern char XLOG_archive_dir[];
---
 >               extern char *XLogArchiveDest;
5410c5410
<               use_wal = XLOG_archive_dir[0] && !rel->rd_istemp;
---
 >               use_wal = XLogArchiveDest[0] && !rel->rd_istemp;


Now I have to see if I have broken it with this change :-)

regards

Mark

Simon Riggs wrote:

>On Wed, 2004-07-14 at 16:55, markw(at)osdl(dot)org wrote:
>  
>
>>On 14 Jul, Simon Riggs wrote:
>>    
>>
>>>PITR Patch v5_1 just posted has Point in Time Recovery working....
>>>
>>>Still some rough edges....but we really need some testers now to give
>>>this a try and let me know what you think.
>>>
>>>Klaus Naumann and Mark Wong are the only [non-committers] to have tried
>>>to run the code (and let me know about it), so please have a look at
>>>[PATCHES] and try it out.
>>>
>>>      
>>>
>
>  
>
>>I just tried applying the v5_1 patch against the cvs tip today and got a
>>couple of rejections.  I'll copy the patch output here.  Let me know if
>>you want to see the reject files or anything else:
>>
>>    
>>
>
>I'm on it. Sorry 'bout that all - midnight fingers.
>
>
>---------------------------(end of broadcast)---------------------------
>TIP 5: Have you checked our extensive FAQ?
>
>               http://www.postgresql.org/docs/faqs/FAQ.html
>  
>

In response to

Responses

pgsql-hackers by date

Next:From: Christopher Kings-LynneDate: 2004-07-15 01:47:37
Subject: Re: Release planning (was: Re: Status report)
Previous:From: David F. SkollDate: 2004-07-15 01:14:19
Subject: Patch for pg_dump: Multiple -t options and new -T option

pgsql-admin by date

Next:From: SAKATA TetsuoDate: 2004-07-15 01:49:21
Subject: Re: Point in Time Recovery
Previous:From: Simon RiggsDate: 2004-07-14 22:56:39
Subject: Re: [HACKERS] Point in Time Recovery

pgsql-patches by date

Next:From: SAKATA TetsuoDate: 2004-07-15 01:49:21
Subject: Re: Point in Time Recovery
Previous:From: Christopher Kings-LynneDate: 2004-07-15 01:27:17
Subject: Re: add missing options to pg_dumpall

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group