Re: Compiling libpq with VisualC

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Compiling libpq with VisualC
Date: 2004-06-19 20:10:10
Message-ID: 40D49DA2.7090400@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Two minor tweaks:

<sys/time.h> in libpq-be.h isn't present on win32 vc6. Apparently, it
isn't used in Linux either; libpq will compile without it. All usages of
gettimeofday throughout the backend don't seem connection related, so
libpq-be.h seems an odd place to include it.

ERROR in elog.h has conflicts with a win32 defined macro; #undef WIN32
solves the conflict (or not including elog.h for libpq purposes would do
too)

Regards,
Andreas

Attachment Content-Type Size
win32.patch text/plain 1.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-06-19 22:01:25 Re: Compiling libpq with VisualC
Previous Message Andreas Pflug 2004-06-19 19:25:45 Re: Tablespace patch review

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2004-06-19 22:01:25 Re: Compiling libpq with VisualC
Previous Message Tom Lane 2004-06-18 16:18:21 Re: pg_ctl vs. Windows locking

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-06-19 21:49:09 Re: eventlog fix
Previous Message Dave Page 2004-06-19 19:44:49 Re: eventlog fix