Skip site navigation (1) Skip section navigation (2)

Re: Result Set Cursor Patch

From: Barry Lind <blind(at)xythos(dot)com>
To: Andy Zeneski <jaz(at)ofbiz(dot)org>
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Re: Result Set Cursor Patch
Date: 2004-05-05 20:15:07
Message-ID: 40994B4B.8070906@xythos.com (view raw or flat)
Thread:
Lists: pgsql-jdbc
Or add a -w to your diff to ignore whitespace differences.

--Barry

Kris Jurka wrote:
> 
> On Wed, 5 May 2004, Andy Zeneski wrote:
> 
> 
>>Kris,
>>
>>Here it is again, I think my IDE reformatted a few classes which caused 
>>this patch to be bigger then it needed to be. Here it is in its current 
>>state.
>>
>>If the formatting is major problem, I can attempt to reformat it to 
>>desired settings. I will need to know what the "preferred" way is. I've 
>>noticed there are several different formats used within these classes, 
>>I could easily run the tree though Jacobe and clean it up. However, 
>>that may be too big for the list. :)
> 
> 
> The formatting is an issue.  Yes, the code is formatted differently all 
> over the driver, but now is not the time to fix that.  There are too many 
> outstanding patches that will conflict with these whitespace changes to 
> try and do something about that now.  I aim to reindent/reformat at the 
> start of 7.5 beta when there shouldn't be many outstanding patches or 
> active development.
> 
> Also just trying to read your patch is difficult because it is impossible 
> to tell if a real change is mixed in with a whitespace change.  Could you 
> resubmit this patch as just your changes.
> 
> Kris Jurka
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
>       joining column's datatypes do not match


In response to

Responses

pgsql-jdbc by date

Next:From: Andy ZeneskiDate: 2004-05-05 21:04:13
Subject: Re: Result Set Cursor Patch
Previous:From: Kris JurkaDate: 2004-05-05 19:46:25
Subject: Re: Result Set Cursor Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group