Skip site navigation (1) Skip section navigation (2)

Re: NO WAIT ...

From: Hans-Jürgen Schönig <postgres(at)cybertec(dot)at>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org, pgman(at)candle(dot)pha(dot)pa(dot)us
Subject: Re: NO WAIT ...
Date: 2004-02-18 19:15:33
Message-ID: 4033B9D5.1030608@cybertec.at (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> =?ISO-8859-1?Q?Hans-J=FCrgen_Sch=F6nig?= <postgres(at)cybertec(dot)at> writes:
> 
>>The problem with adding NO WAIT to specific commands is that is 
>>inheritly unflexible. I think this is why the community has agreed on 
>>implementing it based on GUC.
> 
> 
> I recall no such agreement ... when was this exactly?  In any case
> Bruce's recent complaints about regex_flavor have altered my opinions
> about GUC variables a bit.  They are bigger safety risks than they look,
> especially ones that change semantics and are intended to be modified on
> the fly.

I thought there was an agreement because the GUC version is on the TODO 
list. Anyway ...


>>Do you think it would help to reduce the GUCs flexibility by reducing 
>>the lock levels a user is allowed to define?
> 
> 
> I will vote against the patch no matter what, but I agree that it would
> be less dangerous if it were confined to only apply to a limited set of
> lock types.
> 
> 			regards, tom lane


Tom,

I think we should compromise.
We can restrict it to locks which are high enough or higher to make 
SELECT FOR UPDATE work.
Of course it would have been nice to have full flexibility but I think 
we can have almost the same benefit for lower risk.
How about it? Tom, Bruce - which types of locks do we allow?
I will change the patch then.
Maybe this is the best solution.

	Regards,

		Hans
	
-- 
Cybertec Geschwinde u Schoenig
Schoengrabern 134, A-2020 Hollabrunn, Austria
Tel: +43/2952/30706 or +43/664/233 90 75
www.cybertec.at, www.postgresql.at, kernel.cybertec.at


In response to

Responses

pgsql-hackers by date

Next:From: Larry RosenmanDate: 2004-02-18 19:19:03
Subject: Re: [PATCHES] NO WAIT ...
Previous:From: Tom LaneDate: 2004-02-18 19:12:46
Subject: Re: [PATCHES] NO WAIT ...

pgsql-patches by date

Next:From: Larry RosenmanDate: 2004-02-18 19:19:03
Subject: Re: [PATCHES] NO WAIT ...
Previous:From: Tom LaneDate: 2004-02-18 19:12:46
Subject: Re: [PATCHES] NO WAIT ...

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group