Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Date: 2010-03-26 05:24:35
Message-ID: 3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-docs pgsql-hackers

On Thu, Mar 25, 2010 at 9:55 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> * Fix the bug of a spurious PANIC in archive recovery, if the WAL ends
> in the middle of a WAL record that continues over a WAL segment boundary.
>
> * If a corrupt WAL record is found in archive or streamed from master in
> standby mode, throw WARNING instead of PANIC, and keep trying. In
> archive recovery (ie. standby_mode=off) it's still a PANIC. We can make
> it a WARNING too, which gives the pre-9.0 behavior of starting up the
> server on corruption. I prefer PANIC but the discussion is still going on.

Seems reasonable for me.

> * Small code changes to handling of failedSources, inspired by your
> comment. No change in functionality.
>
> This is also available in my git repository at
> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges"

I looked the patch and was not able to find any big problems until now.
The attached small patch fixes the typo.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
typo.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-03-26 12:23:34 pgsql: Flush CopyOutResponse when starting streaming in walsender, so
Previous Message User Itagaki 2010-03-26 02:36:54 pgbulkload - pgbulkload: pg_bulkload 3.0 Alpha 3.

Browse pgsql-docs by date

  From Date Subject
Next Message Fujii Masao 2010-03-26 13:21:42 Re: [HACKERS] Incrementally Updated Backups and restartpoints
Previous Message Josh Kupershmidt 2010-03-26 03:43:13 docs cleanup patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Albe Laurenz 2010-03-26 08:03:57 Re: Ask help for putting SP-Gist into postgresql
Previous Message Joseph Adams 2010-03-26 03:42:48 Re: Proposal: access control jails (and introduction as aspiring GSoC student)