Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Aidan Van Dyk <aidan(at)highrise(dot)ca>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Make standby server continuously retry restoring the next WAL
Date: 2010-03-26 05:24:35
Message-ID: 3f0b79eb1003252224u9b91cc4la75547c6a2610ffc@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-docspgsql-hackers
On Thu, Mar 25, 2010 at 9:55 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> * Fix the bug of a spurious PANIC in archive recovery, if the WAL ends
> in the middle of a WAL record that continues over a WAL segment boundary.
>
> * If a corrupt WAL record is found in archive or streamed from master in
> standby mode, throw WARNING instead of PANIC, and keep trying. In
> archive recovery (ie. standby_mode=off) it's still a PANIC. We can make
> it a WARNING too, which gives the pre-9.0 behavior of starting up the
> server on corruption. I prefer PANIC but the discussion is still going on.

Seems reasonable for me.

> * Small code changes to handling of failedSources, inspired by your
> comment. No change in functionality.
>
> This is also available in my git repository at
> git://git.postgresql.org/git/users/heikki/postgres.git, branch "xlogchanges"

I looked the patch and was not able to find any big problems until now.
The attached small patch fixes the typo.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: typo.patch
Description: application/octet-stream (1.4 KB)

In response to

Responses

pgsql-docs by date

Next:From: Fujii MasaoDate: 2010-03-26 13:21:42
Subject: Re: [HACKERS] Incrementally Updated Backups and restartpoints
Previous:From: Josh KupershmidtDate: 2010-03-26 03:43:13
Subject: docs cleanup patch

pgsql-hackers by date

Next:From: Albe LaurenzDate: 2010-03-26 08:03:57
Subject: Re: Ask help for putting SP-Gist into postgresql
Previous:From: Joseph AdamsDate: 2010-03-26 03:42:48
Subject: Re: Proposal: access control jails (and introduction as aspiring GSoC student)

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2010-03-26 12:23:34
Subject: pgsql: Flush CopyOutResponse when starting streaming in walsender, so
Previous:From: User ItagakiDate: 2010-03-26 02:36:54
Subject: pgbulkload - pgbulkload: pg_bulkload 3.0 Alpha 3.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group