Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
Date: 2010-03-24 08:36:18
Message-ID: 3f0b79eb1003240136k41f02ad4j9c6e0e552815902c@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Wed, Mar 24, 2010 at 2:25 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> The main thing for me was that it logged something. The above two ways
> occurred to me and figured we'd end up discussing it.
>
> The first way is slightly confusing for the reason stated, agreed. By
> using the same form of words as is used currently, all existing scripts
> that search for connection details will all still work. The second way
> is more informative, if you don't know "replication" is a
> pseudo-database, but it will break all existing scripts.
>
> My own feeling was that breaking existing scripts was not a price worth
> paying for the extra information in the second form of the message,
> since its just the same words re-arranged.

Since the meaning of the first message is different between 8.4 and 9.0
(in 8.4, the normal connection to the database 'replication', in 9.0, the
connection for replication from the standby server), we would still need
to change the existing scripts. No?

What is worse is that we can connect to the real database 'replication'
in 9.0. So we might be unable to discern that normal connection from the
replication connection by seeing the first message.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2010-03-24 10:29:56
Subject: Re: [COMMITTERS] pgsql: Add connection messages for streaming replication.
Previous:From: Pavel StehuleDate: 2010-03-24 07:39:34
Subject: Re: WIP: preloading of ispell dictionary

pgsql-committers by date

Next:From: User ItagakiDate: 2010-03-24 08:42:21
Subject: pgstatsinfo - pg_reporter: New Directory
Previous:From: Heikki LinnakangasDate: 2010-03-24 06:25:39
Subject: pgsql: Update description of walrcv_receive() function to match reality.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group