On Thu, Feb 18, 2010 at 5:28 AM, Heikki Linnakangas
> If I'm reading the patch correctly, when wal_sync_method is 'open_sync',
> walreceiver nevertheless opens the WAL file without the O_DIRECT flag.
> When it later flushes it in XLogWalRcvFlush() by issue_xlog_fsync(),
> issue_xlog_fsync() will do nothing because it assumes the write() synced
> it already. So the data written isn't being forced to disk at all.
When 'open_sync' is chosen, the WAL file is opened with O_SYNC or O_FSYNC
flag. So I think that write() flushes the data to disk even if O_DIRECT
flag is not given. Am I missing something?
> How about just forcing sync_method to 'fsync' in walreceiver?
In win32, O_DSYNC seems to be preferred to 'fsync' so far. So I'm not sure
if reshuffling of priority is harmless.
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
In response to
pgsql-hackers by date
|Next:||From: KaiGai Kohei||Date: 2010-02-18 01:58:14|
|Subject: Re: Large object dumps vs older pg_restore|
|Previous:||From: Tom Lane||Date: 2010-02-18 01:32:25|
|Subject: Re: CommitFest Status Summary - 2010-02-14 |