From:
Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To:
Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc:
Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject:
Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Date:
2010-02-02 04:40:14
Message-ID:
3f0b79eb1002012040r777313bcv4d3b13c72cecc0d8@mail.gmail.com (view raw or flat )
Thread:
2010-01-20 19:43:40 from heikki(at)postgresql(dot)org (Heikki Linnakangas)
2010-01-21 03:40:05 from Robert Haas <robertmhaas(at)gmail(dot)com>
2010-01-21 03:56:20 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-02-01 08:40:57 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-02-01 09:33:44 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-01 09:53:36 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-02-01 10:11:56 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-01 10:14:56 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-02-01 10:30:43 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-01 10:38:44 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-01 10:40:51 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-02 04:40:14 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-03 10:03:00 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-03 10:19:19 from Tatsuo Ishii <ishii(at)postgresql(dot)org>
2010-02-03 10:50:06 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-01 10:46:06 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2010-02-01 09:58:00 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-01 10:15:21 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-01 10:27:15 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2010-02-01 10:36:59 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-01 16:13:50 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-committers pgsql-hackers
On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> So you get those messages when the table is *not* a temporary table. I
> can see now what Fujii was trying to say. His patch seems Ok, though
> perhaps it would be better to move the responsibility of calling
> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
> it in heap_sync(), I didn't take into account that it's sometimes called
> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
> operations.
As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
to the callers of heap_sync(). Here is the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
In response to
Responses
pgsql-hackers by date
Next :From: KaiGai KoheiDate: 2010-02-02 04:49:52
Subject : Re: Largeobject Access Controls (r2460)
Previous :From : Fujii MasaoDate : 2010-02-02 04:33:44
Subject : Re: PITR - Bug or feature?
pgsql-committers by date
Next :From: User ItagakiDate: 2010-02-02 11:08:52
Subject : pgbulkload - pgbulkload: Read control files in the client program, and
Previous :From : User GleuDate : 2010-02-01 20:53:32
Subject : pgsnap - pgsnap: Update index.