| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without |
| Date: | 2010-02-02 04:40:14 |
| Message-ID: | 3f0b79eb1002012040r777313bcv4d3b13c72cecc0d8@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> So you get those messages when the table is *not* a temporary table. I
> can see now what Fujii was trying to say. His patch seems Ok, though
> perhaps it would be better to move the responsibility of calling
> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
> it in heap_sync(), I didn't take into account that it's sometimes called
> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
> operations.
As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
to the callers of heap_sync(). Here is the patch.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| unlogged_operation_by_vacuum_full_20100202.patch | text/x-patch | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | User Itagaki | 2010-02-02 11:08:52 | pgbulkload - pgbulkload: Read control files in the client program, and |
| Previous Message | User Gleu | 2010-02-01 20:53:32 | pgsnap - pgsnap: Update index. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | KaiGai Kohei | 2010-02-02 04:49:52 | Re: Largeobject Access Controls (r2460) |
| Previous Message | Fujii Masao | 2010-02-02 04:33:44 | Re: PITR - Bug or feature? |