Skip site navigation (1) Skip section navigation (2)

updateMinRecoveryPoint bug?

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: updateMinRecoveryPoint bug?
Date: 2009-12-24 04:34:58
Message-ID: 3f0b79eb0912232034v2bac975bu5999aa54ed4fa0b1@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi,

In UpdateMinRecoveryPoint() and XLogNeedsFlush(), updateMinRecoveryPoint
is used for us to short-circuit future checks only during a crash recovery.
But it doesn't seem to play its role in a crash recovery that follows an
archive recovery. Because such crash recovery always starts from *valid*
minRecoveryPoint, i.e., updateMinRecoveryPoint is never set to FALSE.

How about always resetting ControlFile->minRecoveryPoint to {0, 0} at the
beginning of a crash recovery, to fix the bug?

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Responses

pgsql-hackers by date

Next:From: Fujii MasaoDate: 2009-12-24 04:39:32
Subject: Re: Backup history file should be replicated in Streaming Replication?
Previous:From: Yoichi HiraiDate: 2009-12-24 04:29:22
Subject: Corrupt WAL production possible in gistxlog.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group