Re: Reading recovery.conf earlier

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Subject: Re: Reading recovery.conf earlier
Date: 2009-12-07 04:03:10
Message-ID: 3f0b79eb0912062003q1fdc0e06m4830df5a19369110@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Dec 6, 2009 at 2:49 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Proposal is to split out the couple of lines in
> readRecoveryCommandFile() that set important state and make it read in
> an option block that can be used by caller. It would then be called by
> both postmaster (earlier in startup) and again later by startup process,
> as happens now. I want to do it that way so I can read file before we
> create shared memory, so I don't have to worry about passing details via
> shared memory itself.

I agree with the proposal that postmaster reads the recovery.conf.
Because this would enable all child processes to easily obtain the
parameter values in that, like GUC parameters.

But I'm not sure why recovery.conf should be read separately by
postmaster and the startup process. How about making postmaster
read all of that for the simplification?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Smith 2009-12-07 04:19:40 Re: [PATCH] Largeobject Access Controls (r2460)
Previous Message Greg Smith 2009-12-07 04:01:04 Re: YAML Was: CommitFest status/management