Re: BUG #4961: pg_standby.exe crashes with no args

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, wader2 <wader2(at)jcom(dot)home(dot)ne(dot)jp>, pgsql-bugs(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #4961: pg_standby.exe crashes with no args
Date: 2009-11-04 10:40:19
Message-ID: 3f0b79eb0911040240y1c2316a5y7bd5e13115740847@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Hi,

Sorry for this late reply.

On Wed, Aug 19, 2009 at 6:45 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> Is pg_standby killed correctly when postmaster dies?

No. In my test (v8.3.7 on Win), an immediate shutdown was able to
kill postmaster, but not pg_standby and the startup process.

Though we should change those to handle the shutdown signals
correctly, this change is not imperative need. At first, we should
just get rid of the signal support from pg_standby on Win, in order
to avoid the pg_standby crash. The attached is the patch to do so.
If this patch is OK, the backport is required for 8.3.x.

Thought?

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
drop_signal_support_for_pgstandby_win32.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Craig Ringer 2009-11-04 12:30:35 Re: BUG #5163: Admin can't connect and won't use port 5432
Previous Message Bogdan Mihaila 2009-11-04 09:05:55 BUG #5164: COPY command: invalid byte sequence 0x80

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-11-04 12:25:13 Re: Skip WAL in ALTER TABLE
Previous Message KaiGai Kohei 2009-11-04 06:36:15 [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns