Skip site navigation (1) Skip section navigation (2)

Re: pg_standby -l might destory the archived file

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_standby -l might destory the archived file
Date: 2009-06-02 02:39:36
Message-ID: 3f0b79eb0906011939x59d63cf7hbde1f55a5a03a5f4@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Hi,

On Tue, Jun 2, 2009 at 10:21 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> Yes, the old xlog itself is not used again. But, the *old file* might
>> be recycled and used later. The case that I'm looking at is that the
>> symlink to a temporary area is recycled. Am I missing something?
>
> Actually, I think the right fix for that would be to add defenses to
> xlog.c to not try to "recycle" a file that is a symlink.

OK, I tweaked Aidan's patch. Thanks Aidan!
http://archives.postgresql.org/message-id/20090601152736.GL15213@yugib.highrise.ca

Changes are:
- use lstat instead of stat
- add #if HAVE_WORKING_LINK and #endif code

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: not_recycle_symlink.patch
Description: text/x-patch (1.3 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Hiroshi InoueDate: 2009-06-02 03:22:13
Subject: Re: [GENERAL] trouble with to_char('L')
Previous:From: Scott BaileyDate: 2009-06-02 01:55:04
Subject: Re: ruby connect

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group