From:
"Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
To:
"Heikki Linnakangas" <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc:
"Bruce Momjian" <bruce(at)momjian(dot)us>, "Randy Isbell" <jisbell(at)cisco(dot)com>, pgsql-bugs(at)postgresql(dot)org
Subject:
Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
Date:
2009-01-15 14:15:55
Message-ID:
3f0b79eb0901150615g133f845erc39faf19793d5977@mail.gmail.com (view raw or flat )
Thread:
2008-12-05 14:41:16 from "Randy Isbell" <jisbell(at)cisco(dot)com>
2008-12-06 04:29:10 from "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 01:50:31 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-01-15 12:09:57 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 14:15:55 from "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 15:23:46 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 16:15:41 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-15 17:33:44 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-15 17:43:06 from Bruce Momjian <bruce(at)momjian(dot)us>
2009-01-15 17:51:35 from Simon Riggs <simon(at)2ndQuadrant(dot)com>
2009-01-16 02:18:49 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2009-01-16 02:42:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2009-01-16 03:18:38 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2009-01-15 14:25:29 from Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
2009-01-15 23:54:03 from Bruce Momjian <bruce(at)momjian(dot)us>
2010-02-04 07:28:03 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-05 00:08:35 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-02-05 00:54:14 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-16 05:19:15 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
2010-02-17 08:43:19 from Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
2010-02-17 17:07:34 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2010-02-15 09:40:36 from Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Lists:
pgsql-bugs pgsql-docs pgsql-hackers
Hi,
On Thu, Jan 15, 2009 at 9:09 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> I think not
> (http://archives.postgresql.org/pgsql-hackers/2008-12/msg00126.php ). The
> return value of pg_stop_backup() is currently the same as
> pg_switch_xlog()'s: the location of the last byte before the XLOG switch +
> 1. The proposed patch would remove the "+ 1". Seems like an unnecessary API
> change, and I don't recall any reason why the new definition would be
> better.
My patch doesn't change the return value of pg_stop_backup(), it's still
the same as the return value of pg_switch_xlog(). Only a part of backup
history file (the file name including stop wal location) is changed.
Currently, the file name is wrong if stop wal location indicates a boundary
byte. This would confuse the user, I think.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
In response to
Responses
pgsql-docs by date
Next :From: Heikki LinnakangasDate: 2009-01-15 14:25:29Subject : Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL
LOCATIONPrevious :From : Heikki LinnakangasDate : 2009-01-15 12:09:57Subject : Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL
LOCATION
pgsql-hackers by date
Next :From: Heikki LinnakangasDate: 2009-01-15 14:25:29Subject : Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL
LOCATIONPrevious :From : A. KretschmerDate : 2009-01-15 14:06:47Subject : Question regarding new windowing functions in 8.4devel
pgsql-bugs by date
Next :From: Heikki LinnakangasDate: 2009-01-15 14:25:29Subject : Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL
LOCATIONPrevious :From : Milen A. RadevDate : 2009-01-15 14:00:47Subject : Re: BUG #4616: Create Database with another encoding as the encoding
from postgres
