Skip site navigation (1) Skip section navigation (2)

Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

From: "Fujii Masao" <masao(dot)fujii(at)gmail(dot)com>
To: "Randy Isbell" <jisbell(at)cisco(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION
Date: 2008-12-06 04:29:10
Message-ID: 3f0b79eb0812052029r1ee3a7b8n4aec36fc36b09d7a@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-docspgsql-hackers
On Fri, Dec 5, 2008 at 11:41 PM, Randy Isbell <jisbell(at)cisco(dot)com> wrote:
>
> The following bug has been logged online:
>
> Bug reference:      4566
> Logged by:          Randy Isbell
> Email address:      jisbell(at)cisco(dot)com
> PostgreSQL version: 8.3.4
> Operating system:   FreeBSD 6.2
> Description:        pg_stop_backup() reports incorrect STOP WAL LOCATION
> Details:
>
> An inconsistency exists between the segment name reported by
> pg_stop_backup() and the actual WAL file name.
>
>
> SELECT pg_start_backup('filename');
>         pg_start_backup
>        -----------------
>         10/FE1E2BAC
>        (1 row)
>
> Later:
> SELECT pg_stop_backup();
>         pg_stop_backup
>        ----------------
>         10/FF000000
>        (1 row)
>
> The resulting *.backup file:
>
> START WAL LOCATION: 10/FE1E2BAC (file 0000000200000010000000FE)
> STOP WAL LOCATION: 10/FF000000 (file 0000000200000010000000FF)
> CHECKPOINT LOCATION: 10/FE1E2BAC
> START TIME: 2008-11-09 01:15:06 CST
> LABEL: /bck/db/sn200811090115.tar.gz
> STOP TIME: 2008-11-09 01:15:48 CST
>
> In my 8.3.4 instance, WAL file naming occurs as:
>
> ...
> 0000000100000003000000FD
> 0000000100000003000000FE
> 000000010000000400000000
> 000000010000000400000001
> ...
>
> WAL files never end in 'FF'.  This causes a problem when trying to collect
> the ending WAL file for backup.

It's a bug of pg_stop_backup(), which has been talked before.
http://archives.postgresql.org/pgsql-hackers/2008-12/msg00108.php

Attached is a patch against HEAD. I think that we should
also backport.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment: stopxlogfilename_bugfix.patch
Description: text/x-patch (2.9 KB)

In response to

Responses

pgsql-docs by date

Next:From: Bruce MomjianDate: 2008-12-15 23:23:02
Subject: Re: [ADMIN] shared_buffers and shmmax
Previous:From: Randy IsbellDate: 2008-12-05 14:41:16
Subject: BUG #4566: pg_stop_backup() reports incorrect STOP WAL LOCATION

pgsql-hackers by date

Next:From: Robert TreatDate: 2008-12-06 04:33:16
Subject: Re: Mostly Harmless: Welcoming our C++ friends
Previous:From: Robert HaasDate: 2008-12-06 04:25:39
Subject: Re: Simple postgresql.conf wizard

pgsql-bugs by date

Next:From: Heikki LinnakangasDate: 2008-12-06 16:55:11
Subject: Re: BUG #4563: Translation of errors.
Previous:From: Martin PittDate: 2008-12-05 23:24:04
Subject: Re: Fall back to alternative tsearch dictionary directory

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group