Tom Lane wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>There are a couple of other places where [select()] is used for small
>>>sleeps (storage/lmgr/s_lock.c and access/transam/xact.c) -
>>What is the preferred way to handle these 2 cases? We could handle them
>>with #ifdef'd code inline, or create a new function pg_usleep(), or
>>possibly handle it with conditional macros inline. If a new function or
>>macro, where should they go?
>I'd go with a new function. There is no reason to try to "optimize"
>this code by putting it inline; if you're trying to delay, another few
>nanoseconds to enter a subroutine doesn't matter.
>As for where, maybe make a new file in src/port/. That would make it
>relatively easy to use the same function in client-side code if we
patch + new file attached. Haven't tested on Windows, but should be fine.
Description: text/plain (755 bytes)
In response to
pgsql-hackers by date
|Next:||From: Bruce Momjian||Date: 2003-12-30 19:00:48|
|Subject: Re: Is my MySQL Gaining ?|
|Previous:||From: Jason Godden||Date: 2003-12-30 18:57:36|
|Subject: Re: Improving/Adding to Docs (was Is my MySQL Gaining ? or someone missed a date with a dolphin)|
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2003-12-30 23:12:35|
|Subject: Solaris thread patch|
|Previous:||From: Tom Lane||Date: 2003-12-30 17:16:15|
|Subject: Re: [PATCHES] update i386 spinlock for hyperthreading |
pgsql-hackers-win32 by date
|Next:||From: Claudio Natoli||Date: 2003-12-31 02:33:09|
|Subject: Re: pg_usleep|
|Previous:||From: Tom Lane||Date: 2003-12-30 16:51:41|
|Subject: Re: select() for small sleep |