Skip site navigation (1) Skip section navigation (2)

Re: polymorphic arguments and return type for PL/pgSQL

From: Joe Conway <mail(at)joeconway(dot)com>
To:
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,"Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: polymorphic arguments and return type for PL/pgSQL
Date: 2003-06-30 23:20:12
Message-ID: 3F00C5AC.4040205@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-patches
Joe Conway wrote:
> Compiles clean, and passes all regression tests. I'll look to update the 
> docs and regression tests as part of my post freeze array/polymorphic 
> function cleanup.
> 

Oh, almost forgot. I had one question, seen here in 
get_function_by_signature()

> + if (!entry_valid)
> + {
> + 	plpgsql_HashTableDelete(function);
 > +
> + 	/* XXX: is it worth worrying about the leaked function struct? */
> + 	function = NULL;

With the current linked list, the function is effectively leaked to the 
end of the session anyway, so I don't think this is any worse. Thoughts?

Thanks,

Joe


In response to

Responses

pgsql-patches by date

Next:From: Joe ConwayDate: 2003-06-30 23:32:46
Subject: Re: [HACKERS] Missing array support
Previous:From: Joe ConwayDate: 2003-06-30 23:14:42
Subject: Re: polymorphic arguments and return type for PL/pgSQL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group