Re: [HACKERS] Missing array support

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Missing array support
Date: 2003-06-29 20:04:42
Message-ID: 3EFF465A.9060307@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> If I were you I'd file this on the to-fix-later list and concentrate
> on polymorphic aggregates during the next couple days. If that's not
> done by Tuesday it will be a tough sell to put in during beta.

Attached is a patch that implements polymorphic aggregates.

Included in the patch, I changed SQL language functions so that they
could be declared with and use polymorphic types. This was necessary to
facilitate my testing, and I had wanted to implement that all along
anyway (in fact I'd still like to allow PL/pgSQL to use polymorphic
types, but I'll try to do that separately).

The attached compiles cleanly and passes all regression tests. I've also
attached a test script and its output that I used to verify appropriate
behavior of CREATE AGGREGATE. The script attempts to cover all possible
combinations of inputs and outputs (wrt polymorphic vs non-polymorphic).
As far as I can see, the behaviors look correct.

Not sure if it makes sense to do so, but I could either add the test
script to an existing regression test, or create a new one with it if
desired.

If there are no objections, please apply.

Thanks,

Joe

Attachment Content-Type Size
array-polyagg.05.patch text/plain 35.1 KB
array-polyagg-test.sql text/plain 13.3 KB
array-polyagg-test.out text/plain 18.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message PeterKorman 2003-06-29 21:08:14 Re: persistant psql feature suggestion
Previous Message Carlos Guzman Alvarez 2003-06-29 19:34:33 Question about array read using protocol 3.0 implementation in C#

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-06-29 21:24:53 Re: [HACKERS] Missing array support
Previous Message Andreas Pflug 2003-06-29 17:42:46 ruleutils with pretty-print option