Skip site navigation (1) Skip section navigation (2)

Re: contrib/tablefunc bugfix

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: contrib/tablefunc bugfix
Date: 2003-05-04 06:14:23
Message-ID: 3EB4AFBF.9030706@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
> 
>>I did find that contrib/cube fails `make installcheck` due to the bison 
>>error message wording change (...syntax error... vs ... parse error 
>>...). It seems contrib/seg was adjusted for this, but cube was not. Is 
>>there a reason for that, or should I send in a patch?
> 
> Since we are going to be going through substantial error message wording
> changes anyway for 7.4, I'm planning to revert the build-time hack that
> preserves the older bison spelling of the error message; we may as
> well standardize on the bison 1.875 spelling.  So contrib/seg needs its
> hack undone, and both need their expected files updated.  If you wanna
> do that, fine, otherwise I'll get to it when I start doing the backend
> error call updates.

OK -- patch attached. Both cube and seg pass `make installcheck` for me now.

Joe

Attachment: cube-seg.patch
Description: text/plain (6.2 KB)

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2003-05-04 14:05:30
Subject: Re: Disable alternate locations on Win32
Previous:From: Bruce MomjianDate: 2003-05-04 04:43:27
Subject: Disable alternate locations on Win32

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group