Skip site navigation (1) Skip section navigation (2)

Re: GIST_LEAF vs. leaf_key; gist?entryinit

From: Teodor Sigaev <teodor(at)stack(dot)net>
To: Itai Zukerman <zukerman(at)math-hat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: GIST_LEAF vs. leaf_key; gist?entryinit
Date: 2003-03-03 09:51:12
Message-ID: 3E632590.5060108@stack.net (view raw or flat)
Thread:
Lists: pgsql-hackers
gistPageAddItem doesn't used. Look at mail archive, it was a discussion about
keep thes or not. Shortly: gistPageAddItem suppose to recompress entry, but we 
can't
find any reason to do it.  One more - gistPageAddItem works only with
single-key indexes.

Itai Zukerman wrote:
> In the examples I've seen, in the consistent method we have:
> 
>   if (GIST_LEAF(entry)) [...]
> 
> but in compress we have:
> 
>   if (entry->leafkey) [...]
> 
> I can see what the latter's doing, but I'm not sure what GIST_LEAF
> does, or why you'd want to use it.
> 
> Also, I noticed this in src/backend/access/gist:
> 
>   static void gistcentryinit(GISTSTATE *giststate, int nkey,
>                              GISTENTRY *e, Datum k,
>                              Relation r, Page pg,
>                              OffsetNumber o, int b, bool l, bool isNull);
> 
> and later (in gistPageAddItem):
> 
> 	gistcentryinit(giststate, 0, &tmpcentry, dentry->key, r, page,
> 				   offsetNumber, dentry->bytes, FALSE);
> 
> Isn't the call missing the "isNull" parameter?
> 

-- 
Teodor Sigaev
teodor(at)stack(dot)net



In response to

pgsql-hackers by date

Next:From: Teodor SigaevDate: 2003-03-03 09:57:51
Subject: Re: GiST: Bad newtup On Exit From gistSplit() ?
Previous:From: Teodor SigaevDate: 2003-03-03 09:46:00
Subject: Re: [SQL] OffsetNumber, picksplit, and GiST

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group