Re: additional patch for contrib/tablefunc - added to regression

From: Joe Conway <mail(at)joeconway(dot)com>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: additional patch for contrib/tablefunc - added to regression
Date: 2002-09-27 01:17:44
Message-ID: 3D93B1B8.5050805@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gavin Sherry wrote:
> Joe,
>
> This test presumes that it will succeed. That is, if there is an infinite
> recursion here, the test will just hang -- as far as I can tell -- and
> will not *actually* report the failure.

No, look at expected/tablefunc.out:

-- recursion detection
INSERT INTO connectby_int VALUES(10,9);
INSERT INTO connectby_int VALUES(11,10);
INSERT INTO connectby_int VALUES(9,11);
-- should fail due to infinite recursion
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~')
AS t(keyid int, parent_keyid int, level int, branch text);
ERROR: infinite recursion detected
^^^^^^^^^^^^^^^^^^^^^^^^^^^

Unless I'm miss-understanding you?

Joe

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Gavin Sherry 2002-09-27 01:20:52 Re: additional patch for contrib/tablefunc - added to
Previous Message Joe Conway 2002-09-27 01:07:08 additional patch for contrib/tablefunc - added to regression test