Skip site navigation (1) Skip section navigation (2)

Re: make_greater_string busted

From: Joe Conway <mail(at)joeconway(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: make_greater_string busted
Date: 2002-09-18 23:53:50
Message-ID: 3D89120E.2010009@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> I see in your recent bytea-LIKE patch
> 
>         if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
>             len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
>         else
>             len -= -1;
> 
> Surely there's one too many minus signs in that last?

Bug by Joe; review by Tom; patch attached; please apply.

Almost sounds like a short poem ;-)

Joe



Attachment: make_greater_string-fix.1.patch
Description: text/plain (872 bytes)

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2002-09-18 23:56:26
Subject: Re: make_greater_string busted
Previous:From: Neil ConwayDate: 2002-09-18 23:19:55
Subject: to_char() code cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group