Skip site navigation (1) Skip section navigation (2)

Anonymous-record-types omission

From: Joe Conway <mail(at)joeconway(dot)com>
To: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Anonymous-record-types omission
Date: 2002-08-28 04:54:37
Message-ID: 3D6C578D.2070304@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane found an omission in the committed anonymous type code. The 
coldeflist in the FROM clause was not being dumped by ruleutils.c. The 
attached patch fixes this. Example:

-- before --

regression=# \d pg_settings
View "pg_catalog.pg_settings"
  Column  | Type | Modifiers
---------+------+-----------
  name    | text |
  setting | text |
View definition: SELECT a.name, a.setting FROM pg_show_all_settings() a;
Rules: pg_settings_u,
        pg_settings_n

-- and after --

test=# \d pg_settings
View "pg_catalog.pg_settings"
  Column  | Type | Modifiers
---------+------+-----------
  name    | text |
  setting | text |
View definition: SELECT a.name, a.setting FROM pg_show_all_settings() 
a(name text, setting text);
Rules: pg_settings_u,
        pg_settings_n


Also included is the related adjustment to expected/rules.out. If there 
are no objections, please apply.

Thanks,

Joe

Attachment: anon-type-ruleutils.fix.1.patch
Description: text/plain (11.1 KB)

Responses

pgsql-patches by date

Next:From: Gavin SherryDate: 2002-08-28 06:26:47
Subject: Re: [HACKERS] Proposed GUC Variable
Previous:From: Neil ConwayDate: 2002-08-28 04:33:26
Subject: Re: fix for palloc() of user-supplied length

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group