Skip site navigation (1) Skip section navigation (2)

Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)
Date: 2002-05-13 04:08:35
Message-ID: 3CDF3C43.80404@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
> 
>>Here's the patch, per my post to HACKERS.
>>It builds cleanly on my dev box, and passes all regression tests.
> 
> 
> I've committed this with some revisions.  The VIEW cases you were
> worried about seem to work now.  I think you'll find that
> single-FROM-item cases generally work, and it's time to start worrying
> about joins (ie, rescans).

Thanks! I've been offline most of the weekend, but I can get back on 
this now. I'll start work on the rescans and test cases below right 
away. Were your revisions extensive? Any major misconceptions on my part?

Thanks,

Joe


> 
> Parameters also need thought.  This should be rejected:
> 
> regression=# select * from foo, foot(fooid) z where foo.f2 = z.f2;
> server closed the connection unexpectedly
> 
> On the other hand, IMHO this should work:
> 
> regression=# select * from foo where f2 in
> regression-# (select f2 from foot(foo.fooid) z where z.fooid = foo.fooid);
> server closed the connection unexpectedly
> 
> and here again rescanning is going to be critical.
> 
> 			regards, tom lane
> 
> PS: test case for above:
> 
> create table foo(fooid int, f2 int);
> insert into foo values(1, 11);
> insert into foo values(2, 22);
> insert into foo values(1, 111);
> 
> create function foot(int) returns setof foo as '
> select * from foo where fooid = $1' language sql;
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
> 
> http://www.postgresql.org/users-lounge/docs/faq.html




In response to

Responses

pgsql-hackers by date

Next:From: Joel BurtonDate: 2002-05-13 04:12:15
Subject: Re: TRUNCATE
Previous:From: Christopher Kings-LynneDate: 2002-05-13 02:17:07
Subject: Re: TRUNCATE

pgsql-patches by date

Next:From: Tom LaneDate: 2002-05-13 04:31:33
Subject: Re: SRF patch (was Re: [HACKERS] troubleshooting pointers)
Previous:From: Rod TaylorDate: 2002-05-13 02:08:58
Subject: comment on operator / schema

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group