Skip site navigation (1) Skip section navigation (2)

Re: mylog() + qlog() implementation

From: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kristis Makris <kristis(dot)makris(at)datasoft(dot)com>,pgsql-odbc(at)postgresql(dot)org
Subject: Re: mylog() + qlog() implementation
Date: 2002-05-09 01:36:42
Message-ID: 3CD9D2AA.68A74832@tpf.co.jp (view raw or flat)
Thread:
Lists: pgsql-odbc
Tom Lane wrote:
> 
> Kristis Makris <kristis(dot)makris(at)datasoft(dot)com> writes:
> > -#define PG_BINARY_W                  "w"
> > +#define PG_BINARY_W                  "a"
> 
> Surely this would break a lot of other uses?

Practically no. misc.c is the only place where
PG_BINARY_W is used.
 
> I don't object to writing logfiles in append mode... but the
> PG_BINARY_x symbols probably shouldn't be used for logfiles
> in the first place, and in any case we need to distinguish
> "write" from "append" mode.  I think a more extensive patch
> that defines suitable PG_APPEND symbols may be called for.

I would define PG_BINARY_A and change misc.c to use
PG_BINARY_A.

regards,
Hiroshi Inoue
	http://w2422.nsk.ne.jp/~inoue/

In response to

Responses

pgsql-odbc by date

Next:From: Corey W. GibbsDate: 2002-05-09 14:47:24
Subject: Question about VB and Cursor Location
Previous:From: Hiroshi InoueDate: 2002-05-09 01:17:07
Subject: Re: Parse Errors with prepared query

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group