Re: ANSI Compliant Inserts

From: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Rod Taylor <rbt(at)zort(dot)ca>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ANSI Compliant Inserts
Date: 2002-04-16 00:15:23
Message-ID: 3CBB6D1B.E541E119@tpf.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
>
> Hiroshi Inoue wrote:
> > Bruce Momjian wrote:
> > >
> > > Tom Lane wrote:
> > >
> > > > There are a fair number of things in the TODO list that you put there
> > > > because you liked 'em, but that doesn't mean everyone else agrees.
> > > > I certainly will not accept "once it's on the TODO list it cannot be
> > > > questioned"...
> > >
> > > I put it there because I didn't think there was any question.
> >
> > Honetsly I don't understand what TODO means.
> > Can a developer solve the TODOs any way he likes ?
>
> I meant to say there was no question we wanted this item fixed, not that
> there was no need for implementation discussions.
>
> In summary, code changes have three stages:
>
> o Do we want this feature?
> o How do we want the feature to behave?
> o How do we want the feature implemented?
>
> Tom was complaining because the patch appeared without enough discussion
> on these items. However, from my perspective, this is really trying to
> micromanage the process. When people post patches, we aren't forced to
> apply them.

But shouldn't someone check the patch ?
If the patch is small, making the patch seems
the simplest way for anyone but if the patch
is big, it seems painful for anyone to check
the patch. If no one checks the patch, would
we apply the patch blindly or reject it ?

regards,
Hiroshi Inoue

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-04-16 00:47:39 Re: ANSI Compliant Inserts
Previous Message Bruce Momjian 2002-04-15 23:36:04 Re: [GENERAL] Notify argument?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-04-16 00:15:53 Re: default values for views
Previous Message Neil Conway 2002-04-16 00:06:53 Re: default values for views