Skip site navigation (1) Skip section navigation (2)

Re: Sign me up

From: Royce Ausburn <royce(dot)ml(at)inomial(dot)com>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: pgsql-rrreviewers(at)postgresql(dot)org
Subject: Re: Sign me up
Date: 2011-11-15 02:15:40
Message-ID: 3C456296-7744-4C05-B36C-EFB809DF1884@inomial.com (view raw or flat)
Thread:
Lists: pgsql-rrreviewers
On 15/11/2011, at 12:52 PM, Greg Smith wrote:

> On 11/14/2011 04:17 PM, Royce Ausburn wrote:
>> Please give me the simpler patches -- I've been using pgsql for years, but only read some pgsql code a couple of months ago ;)  I'm not strong in C either, but I'll nut it out.
>>   
> 
> How about "Include detailed information about a row failing a CHECK constraint into the error message"?  There's not a lot of code there, the main review work is preparing a test case that demonstrates the code does its job.  (One really should have been included with the patch, but this condition isn't difficult to recreate)  If that sounds reasonable, just edit the patch and add yourself there.  I see you've already created your own entry there, so you know how that works.

Thanks Greg.  I've added myself.  I'll review it in the next couple of days.

In response to

pgsql-rrreviewers by date

Next:From: Kevin GrittnerDate: 2011-11-15 22:04:58
Subject: FlexLock patch
Previous:From: Greg SmithDate: 2011-11-15 01:52:56
Subject: Re: Sign me up

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group