| From: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Vadim Mikheev <vmikheev(at)sectorbase(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Glitches in heapam.c xlog redo routines |
| Date: | 2001-12-28 04:13:31 |
| Message-ID: | 3C2BF16B.C2784F00@tpf.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>
> These things look like bugs to me:
>
> heap_xlog_clean doesn't update the page's LSN and SUI.
>
> heap_xlog_insert and heap_xlog_update leave random bits in the
> inserted/updated tuple's t_ctid. heap_xlog_update leaves random
> bits in the updated tuple's t_cmax in the "move" case.
As far as I see, t_cmax isn't used anywhere once a tuple
was committed.
>
> I am not sure about what sort of visible fault these omissions could
> produce; perhaps none. But they look like dangerous things IMHO.
> Comments?
I'm not sure about the heap_xlog_clean case. Updating
LSN and SUI seems better to me.
regards,
Hiroshi Inoue
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-12-28 04:20:33 | Re: psql misbehaves because of a simple typo |
| Previous Message | Tom Lane | 2001-12-28 04:11:37 | Re: psql misbehaves because of a simple typo |