Skip site navigation (1) Skip section navigation (2)

Re: More fixes for missing double quotes in the shell scripts

From: Justin <justin(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL Patches Mailing List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: More fixes for missing double quotes in the shell scripts
Date: 2001-09-27 03:44:58
Message-ID: 3BB2A0BA.CAE251C@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-patches
Heh Heh Heh

It's cool with me.

I'll resubmit patches tonight which don't go "over the top" in this way
then.

:)

Regards and best wishes,

Justin Clift


Tom Lane wrote:
> 
> Justin <justin(at)postgresql(dot)org> writes:
> > If there's really something fundamentally wrong with this idea, then
> > let's only do the necessary ones.
> 
> No, nothing fundamentally wrong.  I just prefer to avoid unnecessary
> notational clutter.  Your approach of "let's quote *every* shell
> variable" is defensible but I find it a tad over-the-top.  Comes down
> to a judgment call about code legibility, I suppose.
> 
>                         regards, tom lane

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2001-09-27 04:08:29
Subject: Re: Problem with setlocale (found in libecpg) [accessing a
Previous:From: Tom LaneDate: 2001-09-27 03:43:14
Subject: Re: More fixes for missing double quotes in the shell scripts

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group