Re: More fixes for missing double quotes in the shell scripts

From: Justin <justin(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Justin Clift <justin(at)postgresql(dot)org>, PostgreSQL Patches Mailing List <pgsql-patches(at)postgresql(dot)org>
Subject: Re: More fixes for missing double quotes in the shell scripts
Date: 2001-09-27 03:09:41
Message-ID: 3BB29875.222B783C@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Hi Tom,

I agree it's not strictly necessary, but I thought I'd add them in to
follow the generic "good programming practise" of always quoting
variables in shell script tests.

As far as I'm aware it doesn't break compatility on any system, and it
makes for greater "consistency".

If there's really something fundamentally wrong with this idea, then
let's only do the necessary ones.

:)

+ Justin

Tom Lane wrote:
>
> Surely it's not necessary to put double quotes around $? ...
> that can only have an integral value, no?
>
> regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-09-27 03:43:14 Re: More fixes for missing double quotes in the shell scripts
Previous Message Bruce Momjian 2001-09-26 23:56:00 Re: How to diff a man page?