Re: [HACKERS] Re: WIN32 errno patch

From: Mikhail Terekhov <terekhov(at)emc(dot)com>
To: mag(at)fbab(dot)net, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgman(at)candle(dot)pha(dot)pa(dot)us
Subject: Re: [HACKERS] Re: WIN32 errno patch
Date: 2001-08-21 20:31:45
Message-ID: 3B82C531.AE43B0E1@emc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Any chance to review/apply this patch?

Regards,
Mikhail Terekhov

Mikhail Terekhov wrote:
>
> "Magnus Naeslund(f)" wrote:
> >
> > This is a multi-part message in MIME format.
> >
> > ------=_NextPart_000_0106_01C12801.00DAC460
> > Content-Type: text/plain; charset="iso-8859-1"
> > Content-Transfer-Encoding: 7bit
> >
> > Ok, where's a "system dependent hack" :)
> > It seems that win9x doesn't have the "netmsg.dll" so it defaults to "normal"
> > FormatMessage.
> > I wonder if one could load wsock32.dll or winsock.dll on those systems
> > instead of netmsg.dll.
> >
> > Mikhail, could you please test this code on your nt4 system?
> > Could someone else test this code on a win98/95 system?
> >
> > It works on win2k over here.
> >
> > (code attached)
> >
> > Magnus
>
> It works on win2k here too but not on win98/95 or winNT.
> Anyway, attached is the patch which uses Magnus's my_sock_strerror
> function (renamed to winsock_strerror). The only difference is that
> I put the code to load and unload netmsg.dll in the libpqdll.c
> (is this OK Magnus?).
>
> Regards
> Mikhail Terekhov
>
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> Name: libpq.patch.gz
> libpq.patch.gz Type: Gsview32 File (application/x-gzip)
> Encoding: base64

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2001-08-21 20:39:54 pgsql/src/interfaces/libpq fe-connect.c fe-exe ...
Previous Message Tom Lane 2001-08-21 18:21:29 Re: pgsql/src/pl/plpgsql/src Makefile

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2001-08-21 20:50:04 Re: JDBC changes for 7.2... some questions...
Previous Message Ian Lance Taylor 2001-08-21 20:26:26 Re: List response time...

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-08-21 20:57:24 Re: Array Support Fix
Previous Message Greg Zoller 2001-08-21 20:12:20 Array Support Fix