Skip site navigation (1) Skip section navigation (2)

Re: Shutdown hook imp

From: Barry Lind <barry(at)xythos(dot)com>
To: Joseph Shraibman <jks(at)selectacast(dot)net>
Cc: "'pgsql-jdbc(at)postgresql(dot)org'" <pgsql-jdbc(at)postgresql(dot)org>, "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Shutdown hook imp
Date: 2001-07-10 18:07:46
Message-ID: 3B4B4472.4050507@xythos.com (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
I don't think this patch is a good idea because:

a) its only purpose is to supress warning messages in the server log 
when the client isn't coded properly (i.e. the client application should 
be closing connections gracefully/explicitly before calling exit()).

b) The costs of this patch are great IMHO:
   1) increased complexity by having a JDK1.3 specific build
   2) increased support costs (why I am getting error XXX when I run 
under JRUN?) (I have already seen more emails to the list about having 
problems with this feature than I have ever saw about the warning 
messages it supresses).
   3) Increased complexity for users needing to run under JRUN (and 
possibly other JSEE servers) because it requires editing the security 
manager settings to allow the JDBC driver to do this privileged operation.
   4) Possibly incourages a security hole if the user does 3 above 
incorrectly and simply disables the security check, instead of 
selectively disabling it for just the JDBC driver.

I see the costs far outweighing the benefits in this case.

thanks,
--Barry

Joseph Shraibman wrote:

> I've attached a zip of diffs for the jdbc drivers to implement the
> shutdown hook.  Someone who knows ant has to modify what I did so it
> only builds in jdk 1.3+
> 
> I wasn't able to build this and check if it works (something about the
> way things are in the cvs tree snapshot I was working out of) but the
> java files are free of syntax errors.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
> 
> jdbc_shutdown_hook_diffs.zip
> 
> Content-Type:
> 
> application/x-zip-compressed
> Content-Encoding:
> 
> base64
> 
> 
> ------------------------------------------------------------------------
> Part 1.3
> 
> Content-Type:
> 
> text/plain
> Content-Encoding:
> 
> binary
> 
> 



In response to

Responses

pgsql-patches by date

Next:From: Joseph ShraibmanDate: 2001-07-10 19:33:29
Subject: Re: Re: Backups WAS: 2 gig file size limit
Previous:From: Neil ConwayDate: 2001-07-10 16:54:28
Subject: patch for spelling mistake

pgsql-jdbc by date

Next:From: Steve WamplerDate: 2001-07-10 18:07:53
Subject: Re: Too much data received?
Previous:From: Steve WamplerDate: 2001-07-10 16:58:40
Subject: Re: [JDBC] Re: Too much data received?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group