Skip site navigation (1) Skip section navigation (2)

Re: Australian timezone configure option

From: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Chris Dunlop <chris(at)onthe(dot)net(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Australian timezone configure option
Date: 2001-06-14 00:29:18
Message-ID: 3B28055E.A33277EC@alumni.caltech.edu (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> Now I'm going to object LOUDLY.  You cannot convince me that the above
> is a good implementation --- it's a complete crock, and will break the
> instant someone looks at it sidewise.

But it hasn't broken in years of use and maintenance, so that does not
sound like an issue. Eventually, we may want full localization with
character sets *and* date/time conventions, and all of this can be
rethought at that time.

> My inclination would actually be to rip out the cache entirely.  bsearch
> in a table this size is not so expensive that we need to bypass it, nor
> is it apparent that we are going to see lots of successive lookups for
> the same keyword anyway.  How long has that cache been in there, and
> what was the motivation for adding it to begin with?

The cache lookup came from the gods themselves at Berkeley ;)

                   - Thomas

In response to

Responses

pgsql-hackers by date

Next:From: Chris DunlopDate: 2001-06-14 00:42:08
Subject: Re: Australian timezone configure option
Previous:From: Thomas LockhartDate: 2001-06-14 00:23:22
Subject: Re: Australian timezone configure option

pgsql-patches by date

Next:From: Chris DunlopDate: 2001-06-14 00:42:08
Subject: Re: Australian timezone configure option
Previous:From: Thomas LockhartDate: 2001-06-14 00:23:22
Subject: Re: Australian timezone configure option

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group