Skip site navigation (1) Skip section navigation (2)

Re: xlog location arithmetic

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Euler Taveira de Oliveira <euler(at)timbira(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: xlog location arithmetic
Date: 2012-03-09 19:26:44
Message-ID: 3993.1331321204@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Yeah, the use of XLogFile to mean something other than, well a file in
>> the xlog, is greatly annoying.. I guess we could change it, but it
>> goes pretty deep in the system so it's not a small change...

> The whole thing was built around the lack of 64 bit integers.  If we bit
> the bullet and changed the whole thing to be just a single 64-bit
> counter, we could probably delete thousands of lines of code.

Hm.  I think "thousands" is an overestimate, but yeah the logic could be
greatly simplified.  However, I'm not sure we could avoid breaking the
existing naming convention for WAL files.  How much do we care about
that?

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2012-03-09 19:34:04
Subject: Re: xlog location arithmetic
Previous:From: Peter EisentrautDate: 2012-03-09 19:23:28
Subject: Re: xlog location arithmetic

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group