Re: [COMMITTERS] pgsql: Remove typename from A_Const.

alvherre(at)postgresql(dot)org (Alvaro Herrera) writes:
> Remove typename from A_Const.

I'm thinking this could be cleaned up further. The patch as applied
removes the ::int4 typename decoration that had been inserted by
makeIntConst(), while leaving in place the ::float8 decoration inserted
by makeFloatConst(). The kindest thing that can be said about that
is that it's inconsistent. Now as far as I can see in a look through
gram.y, these routines (and makeAConst) were used only in places where
the typename qualification was really unnecessary, that is typmods
and GUC variable values and so on, not general expression contexts where
we might really need to determine a data type for the constant. So what
I'm thinking is that we should get rid of the ::float8 decoration too,
and thereby be able to revert some of the ugly code added elsewhere such
as guc.c.

Is there a reason it was done this way that I'm missing?

regards, tom lane